lkml.org 
[lkml]   [2011]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: ASoC: uninitialized variable i used in wait_for_dc_servo
2011/9/15 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Thu, Sep 15, 2011 at 10:52:34AM +0800, Axel Lin wrote:
>> @@ -722,7 +723,7 @@ static void wait_for_dc_servo(struct snd_soc_codec *codec, u16 mask)
>>
>>               } else {
>>                       msleep(1);
>> -                     if (--i) {
>> +                     if (--i == 0) {
>
> You should avoid making random stylistic changes that aren't needed when
> doing things like this.
>
Ah. I didn't mean to change the coding style.
It's to reverse the logic of the if condition.

BTW, your fix looks good to me.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-09-15 13:17    [W:0.222 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site