Messages in this thread | | | Date | Wed, 14 Sep 2011 20:47:24 +0900 | Subject | Re: [PATCH v2 2/3] mmc: add module param to set fault injection attributes | From | Akinobu Mita <> |
| |
2011/9/14 Per Forlin <per.forlin@linaro.org>:
>>>> +static int fail_mmc_request_param_set(const char *val, >>>> + const struct kernel_param *kp) >>>> +{ >>>> + setup_fault_attr(&fail_default_attr, (char *) val); > I am thinking of returning failure here if setup_fault_attr() fails. > if (setup_fault_attr(&fail_default_attr, (char *) val) == 0) > return -EINVAL;
It's good idea and it also prevents from loading the module if invalid parameter is specified.
> There will be a printk(KERN_WARNING "FAULT_INJECTION: failed to parse > arguments) it setup() fails. Is it too harsh to return failure?
Yes. I'll try to fix in the future. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |