Messages in this thread Patch in this message | | | From | Tao Ma <> | Subject | [PATCH RESEND] block: Don't check QUEUE_FLAG_SAME_COMP in __blk_complete_request. | Date | Wed, 14 Sep 2011 15:23:12 +0800 |
| |
From: Tao Ma <boyu.mt@taobao.com>
In __blk_complete_request, we check both QUEUE_FLAG_SAME_COMP and req->cpu to decide whether we should use req->cpu. Actually the user can also select the complete cpu by either setting BIO_CPU_AFFINE or by calling bio_set_completion_cpu. Current solution makes these 2 ways don't work any more. So we'd better just check req->cpu.
Cc: Jens Axboe <jaxboe@fusionio.com> Signed-off-by: Tao Ma <boyu.mt@taobao.com> --- block/blk-softirq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/blk-softirq.c b/block/blk-softirq.c index 58340d0..1366a89 100644 --- a/block/blk-softirq.c +++ b/block/blk-softirq.c @@ -115,7 +115,7 @@ void __blk_complete_request(struct request *req) /* * Select completion CPU */ - if (test_bit(QUEUE_FLAG_SAME_COMP, &q->queue_flags) && req->cpu != -1) { + if (req->cpu != -1) { ccpu = req->cpu; if (!test_bit(QUEUE_FLAG_SAME_FORCE, &q->queue_flags)) { ccpu = blk_cpu_to_group(ccpu); -- 1.7.1
| |