lkml.org 
[lkml]   [2011]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 2/2] mm: restrict access to /proc/slabinfo
On Wed, Sep 14, 2011 at 11:41 -0700, Dave Hansen wrote:
> On Sat, 2011-09-10 at 20:41 +0400, Vasiliy Kulikov wrote:
> > @@ -4584,7 +4584,8 @@ static const struct file_operations proc_slabstats_operations = {
> >
> > static int __init slab_proc_init(void)
> > {
> > - proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
> > + proc_create("slabinfo", S_IWUSR | S_IRUSR, NULL,
> > + &proc_slabinfo_operations);
> > #ifdef CONFIG_DEBUG_SLAB_LEAK
> > proc_create("slab_allocators", 0, NULL, &proc_sla
>
> If you respin this, please don't muck with the whitespace.

OK, I was just removing checkpatch warnings.

> Otherwise,
> I'm fine with this. Distros are already starting to do this anyway in
> userspace.
>
> Reviewed-by: Dave Hansen <dave@linux.vnet.ibm.com>

Thank you!

--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments


\
 
 \ /
  Last update: 2011-09-14 21:17    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site