lkml.org 
[lkml]   [2011]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/1] Trivial: Eliminate the ret variable from mm_take_all_locks
Date
The ret variable is really not needed in mm_take_all_locks as per
the current flow of the mm_take_all_locks function.

So, eliminating this return variable.

Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
---
mm/mmap.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index a65efd4..48bc056 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2558,7 +2558,6 @@ int mm_take_all_locks(struct mm_struct *mm)
{
struct vm_area_struct *vma;
struct anon_vma_chain *avc;
- int ret = -EINTR;

BUG_ON(down_read_trylock(&mm->mmap_sem));

@@ -2579,13 +2578,12 @@ int mm_take_all_locks(struct mm_struct *mm)
vm_lock_anon_vma(mm, avc->anon_vma);
}

- ret = 0;
+ return 0;

out_unlock:
- if (ret)
- mm_drop_all_locks(mm);
+ mm_drop_all_locks(mm);

- return ret;
+ return -EINTR;
}

static void vm_unlock_anon_vma(struct anon_vma *anon_vma)
--
1.7.6


\
 
 \ /
  Last update: 2011-09-13 12:33    [W:0.029 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site