lkml.org 
[lkml]   [2011]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix repeatable Oops on container destroy with conntrack
On Mon, Sep 12, 2011 at 10:25:24AM +0300, Alexey Dobriyan wrote:
> On Sat, Sep 10, 2011 at 07:48:43PM +0100, Alex Bligh wrote:
> > --- a/net/netfilter/nf_conntrack_netlink.c
> > +++ b/net/netfilter/nf_conntrack_netlink.c
> > @@ -570,6 +570,11 @@ ctnetlink_conntrack_event(unsigned int events, struct nf_ct_event *item)
> > return 0;
> >
> > net = nf_ct_net(ct);
> > +
> > + /* container deinit, netlink may have died before death_by_timeout */
> > + if (!net->nfnl)
> > + return 0;
> > +
> > if (!item->report && !nfnetlink_has_listeners(net, group))
> > return 0;
>
> If this is correct fix, ->nfnl check should be folded into
> nfnetlink_has_listeners(), otherwise expectations aren't covered.

Agreed.


\
 
 \ /
  Last update: 2011-09-12 11:39    [W:0.054 / U:0.484 seconds]
©2003-2014 Jasper Spaans. Advertise on this site