lkml.org 
[lkml]   [2011]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] staging: et131x: Fix checkpatch whitespace warnings
    On Sat, Sep 03, 2011 at 12:49:06PM +0100, Mark Einon wrote:
    > --- a/drivers/staging/et131x/et131x_netdev.c
    > +++ b/drivers/staging/et131x/et131x_netdev.c
    > @@ -408,7 +408,7 @@ void et131x_tx_timeout(struct net_device *netdev)
    > unsigned long flags;
    >
    > /* If the device is closed, ignore the timeout */
    > - if (~(adapter->flags & fMP_ADAPTER_INTERRUPT_IN_USE));
    > + if (~(adapter->flags & fMP_ADAPTER_INTERRUPT_IN_USE))
    > return;
    >

    You fixed a bug here. That's not mentioned in the commit message.
    Why would you want to keep that a secret? Also it should go in a
    separate commit.

    But otherwise this patch looks good.

    regards,
    dan carpenter



    \
     
     \ /
      Last update: 2011-09-10 07:25    [W:0.020 / U:64.240 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site