lkml.org 
[lkml]   [2011]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2] staging: et131x: Fix checkpatch whitespace warnings
    From
    On 10 September 2011 06:22, Dan Carpenter <error27@gmail.com> wrote:
    > On Sat, Sep 03, 2011 at 12:49:06PM +0100, Mark Einon wrote:
    >> --- a/drivers/staging/et131x/et131x_netdev.c
    >> +++ b/drivers/staging/et131x/et131x_netdev.c
    >> @@ -408,7 +408,7 @@ void et131x_tx_timeout(struct net_device *netdev)
    >>       unsigned long flags;
    >>
    >>       /* If the device is closed, ignore the timeout */
    >> -     if (~(adapter->flags & fMP_ADAPTER_INTERRUPT_IN_USE));
    >> +     if (~(adapter->flags & fMP_ADAPTER_INTERRUPT_IN_USE))
    >>               return;
    >>
    >
    > You fixed a bug here.  That's not mentioned in the commit message.
    > Why would you want to keep that a secret?  Also it should go in a
    > separate commit.

    Oh yes, i did, didn't I? I must have forgot that was there.

    Thanks for the spot.

    Would you like it in a different patch?


    Cheers,

    Mark
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-09-10 18:37    [W:0.029 / U:122.268 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site