Messages in this thread | | | Date | Sun, 11 Sep 2011 10:06:19 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH] arch/x86/mm/numa.c: quiet sparse noise when CONFIG_X86_64 is not set |
| |
Hello,
On Sat, Sep 10, 2011 at 02:39:02AM -0700, David Rientjes wrote: > On Fri, 9 Sep 2011, H Hartley Sweeten wrote: > > > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > > index fbeaaf4..11c60a7 100644 > > --- a/arch/x86/mm/numa.c > > +++ b/arch/x86/mm/numa.c > > @@ -455,6 +455,7 @@ void __init numa_set_distance(int from, int to, int distance) > > numa_distance[from * numa_distance_cnt + to] = distance; > > } > > > > +#ifdef CONFIG_X86_64 > > int __node_distance(int from, int to) > > { > > if (from >= numa_distance_cnt || to >= numa_distance_cnt) > > @@ -462,6 +463,7 @@ int __node_distance(int from, int to) > > return numa_distance[from * numa_distance_cnt + to]; > > } > > EXPORT_SYMBOL(__node_distance); > > +#endif > > > > /* > > * Sanity check to catch more bad NUMA configurations (they are amazingly > > > > What is 64-bit specific about this function? Shouldn't we be defining it > to be node_distance for all of x86?
Yeap, that's a remnant of the old separate code paths, which wasn't discovered because asm-generic/topology.h defines fallback node_distance() automatically. We should drop #ifdef from arch/x86/include/asm/topology.h::node_distance(). Hartley, can you please send a patch to do that?
Thanks.
-- tejun
| |