Messages in this thread | | | Date | Thu, 1 Sep 2011 15:18:54 -0700 | From | "Darrick J. Wong" <> | Subject | Re: [PATCH 3/3] crc32c: Implement a self-test for CRC32c |
| |
On Thu, Sep 01, 2011 at 12:40:08AM -0500, Bob Pearson wrote: > Hi Darrick, > > The same code in crc32.c was helpful to measure performance and help code > tuning as well as indicate correctness. Otherwise the code in crypto may be > enough to test all the corner cases. If this survives the review I wonder if > there is a way to combine crc32 and crc32c together somehow. I like yours > because you can load/unload and not need the memory permanently.
I suspect it would be pretty easy to adapt the Makefile to generate the relevant .c and .h files; in particular it could be useful to use the crypto framework for crc32 on the off chance anyone wants to provide hwaccel for that too.
That said, merging libcrc32c-test vectors with the existing one (sorry, I didn't realize that existed) shouldn't be too difficult.
--D
| |