lkml.org 
[lkml]   [2011]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: Tegra I2C driver compilation failure (was: RE: [PATCH] dt: add empty of_get_property for non-dt)
    Stephen Warren wrote at Tuesday, August 09, 2011 10:22 AM:
    > Stephen Warren wrote at Monday, August 08, 2011 1:26 PM:
    > > Rob Herring wrote at Sunday, August 07, 2011 8:38 AM:
    > > > On 08/05/2011 05:50 PM, Stephen Warren wrote:
    > > > > The patch adds empty function of_get_property for non-dt build, so that
    > > > > drivers migrating to dt can save some '#ifdef CONFIG_OF'.
    > > > >
    > > > > This also fixes the current Tegra compile problem in linux-next.
    > > >
    > > > You could just use of_property_read_u32 in the driver. It already has
    > > > empty version and will simplify the driver code some.
    > >
    > > Yes, that would also work.
    > >
    > > Grant, Ben, do you have a preference for which option to choose?
    >
    > Well, all three possible fixes have been posted now:
    >
    > Add ifdef to i2c driver:
    > http://www.spinics.net/lists/linux-tegra/msg01720.html
    >
    > Implement empty of_get_property:
    > http://www.spinics.net/lists/linux-tegra/msg01881.html

    Grant has merged this one into a devicetree branch. Thanks!

    > Switch i2c driver to use of_property_read_u32:
    > http://permalink.gmane.org/gmane.linux.ports.arm.kernel/127807
    >
    > Ben, please could you please pick one of the changes and apply it, so
    > that linux-next compiles for Tegra? Thanks!

    --
    nvpublic



    \
     
     \ /
      Last update: 2011-08-09 19:33    [W:0.022 / U:1.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site