lkml.org 
[lkml]   [2011]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Re: Build failure: bisected: v3.1-rc1 with config ARCH_OMAP && !ARCH_OMAP4 fails with linker error
    * Péter Ujfalusi <peter.ujfalusi@ti.com> [110809 06:15]:
    > Hi Tony, Paul,
    >
    > On Tuesday 09 August 2011 15:14:53 Tony Lindgren wrote:
    > > * Paul Walmsley <paul@pwsan.com> [110808 13:31]:
    > > > Hi
    > > >
    > > > On Mon, 8 Aug 2011, Daniel Morsing wrote:
    > > > > Building the v3.1-rc1 kernel with ARCH_OMAP && !ARCH_OMAP4 support
    > > > > fails on linking with the following error
    > > > >
    > > > > ...
    > > > >
    > > > > LD .tmp_vmlinux1
    > > > >
    > > > > arch/arm/mach-omap2/built-in.o:(.data+0xf7d8): undefined reference
    > > > > to `omap4430_phy_init'
    > > > > arch/arm/mach-omap2/built-in.o:(.data+0xf7dc): undefined reference
    > > > > to `omap4430_phy_exit'
    > > > > arch/arm/mach-omap2/built-in.o:(.data+0xf7e0): undefined reference
    > > > > to `omap4430_phy_power'
    > > > > arch/arm/mach-omap2/built-in.o:(.data+0xf7e4): undefined reference
    > > > > to `omap4430_phy_set_clk'
    > > > > arch/arm/mach-omap2/built-in.o:(.data+0xf7e8): undefined reference
    > > > > to `omap4430_phy_suspend'
    > > > >
    > > > > I've bisected the first bad commit to "OMAP4: Move common twl6030
    > > > > configuration to twl-common" (commit-id
    > > > > b22f954bae35be115a10c6426dc070f7d652b32e). The problem seems to be
    > > > > unconditionally taking a function pointer to an omap4430 specific
    > > > > function in arch/arm/mach-omap2/twl-common.c. The definition for
    > > > > omap4430_phy_init and friends is in
    > > > > arch/arm/mach-omap2/omap_phy_internal.c, which is only compiled when
    > > > > building with support for one of the omap4430 boards.
    > > >
    > > > Thanks for the bisect; this should be fixed by
    > > >
    > > > https://patchwork.kernel.org/patch/963462/
    > >
    > > Hmm, there are also these when CONFIG_ARCH_OMAP4 is not selected:
    > >
    > > arch/arm/mach-omap2/built-in.o: In function `_enable_module':
    > > arch/arm/mach-omap2/omap_hwmod.c:701: undefined reference to
    > > `omap4_cminst_module_enable' arch/arm/mach-omap2/built-in.o: In function
    > > `_disable_module':
    > > arch/arm/mach-omap2/omap_hwmod.c:726: undefined reference to
    > > `omap4_cminst_module_disable' arch/arm/mach-omap2/built-in.o: In function
    > > `_wait_target_disable': arch/arm/mach-omap2/omap_hwmod.c:1179: undefined
    > > reference to `omap4_cminst_wait_module_idle' distcc[27594] ERROR: compile
    > > (null) on localhost failed
    > > make: *** [.tmp_vmlinux1] Error 1
    > >
    > > Care to take a look?
    >
    > I just sent a patch fixing this:
    > http://marc.info/?l=linux-omap&m=131289342114258&w=2

    But that still won't fix the omap4_cminst_* errors, only the omap4430_phy_*
    errors AFAIK.

    Tony
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-08-09 15:43    [W:0.040 / U:60.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site