lkml.org 
[lkml]   [2011]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 05/11] DIO: Separate map_bh from dio v2
    Date
    Andi Kleen <andi@firstfloor.org> writes:

    > From: Andi Kleen <ak@linux.intel.com>
    >
    > Only a single b_private field in the map_bh buffer head is needed after
    > the submission path. Move map_bh separately to avoid storing
    > this information in the long term slab.
    >
    > This avoids the weird 104 byte hole in struct dio_submit which also needed
    > to be memseted early.
    >
    > v2: b_private->private (hch)
    > Signed-off-by: Andi Kleen <ak@linux.intel.com>

    > @@ -1045,6 +1051,7 @@ direct_io_worker(int rw, struct kiocb *iocb, struct inode *inode,
    > ssize_t ret = 0;
    > ssize_t ret2;
    > size_t bytes;
    > + struct buffer_head map_bh = { 0, };

    So long as that zeroes the entire struct (seems to), I'm okay with this patch.

    Cheers,
    Jeff


    \
     
     \ /
      Last update: 2011-08-08 20:15    [W:0.020 / U:93.476 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site