Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH 05/11] DIO: Separate map_bh from dio v2 | Date | Mon, 08 Aug 2011 14:11:44 -0400 |
| |
Andi Kleen <andi@firstfloor.org> writes:
> From: Andi Kleen <ak@linux.intel.com> > > Only a single b_private field in the map_bh buffer head is needed after > the submission path. Move map_bh separately to avoid storing > this information in the long term slab. > > This avoids the weird 104 byte hole in struct dio_submit which also needed > to be memseted early. > > v2: b_private->private (hch) > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> @@ -1045,6 +1051,7 @@ direct_io_worker(int rw, struct kiocb *iocb, struct inode *inode, > ssize_t ret = 0; > ssize_t ret2; > size_t bytes; > + struct buffer_head map_bh = { 0, };
So long as that zeroes the entire struct (seems to), I'm okay with this patch.
Cheers, Jeff
| |