lkml.org 
[lkml]   [2011]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/11] DIO: Separate fields only used in the submission path from struct dio
Date
Andi Kleen <andi@firstfloor.org> writes:

> From: Andi Kleen <ak@linux.intel.com>
>
> This large, but largely mechanic, patch moves all fields in struct dio
> that are only used in the submission path into a separate on stack
> data structure. This has the advantage that the memory is very likely
> cache hot, which is not guaranteed for memory fresh out of kmalloc.
>
> This also gives gcc more optimization potential because it can easier
> determine that there are no external aliases for these variables.
>
> The sdio initialization is a initialization now instead of memset.
> This allows gcc to break sdio into individual fields and optimize
> away unnecessary zeroing (after all the functions are inlined)
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

The pages array is only used on submission. Why did it land in the
struct dio? I would also think you'd want to keep it close to
curr_page, head, tail.

Cheers,
Jeff


\
 
 \ /
  Last update: 2011-08-08 20:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site