Messages in this thread | | | Date | Mon, 8 Aug 2011 09:30:10 -0700 | From | Jesse Barnes <> | Subject | Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked |
| |
On Sat, 6 Aug 2011 10:54:06 -0700 Keith Packard <keithp@keithp.com> wrote:
> There's no reason to relock them; it just makes operations more > complex. This fixes DPMS where the panel registers were locked making > the disable not work. > > Signed-off-by: Keith Packard <keithp@keithp.com>
Yep, looks fine. The only think we might want to sprinkle about are checks for panel off so we can avoid visible corruption if we whack timing or fb stuff while the panel is on.
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
-- Jesse Barnes, Intel Open Source Technology Center
| |