lkml.org 
[lkml]   [2011]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dmaengine/dmatest: Terminate transfers on all channels in case of error or exit
From
Date
On Fri, 2011-07-29 at 16:21 +0530, Viresh Kumar wrote:
> In case, some error occurs while doing memcpy transfers, we must terminate all
> transfers physically too. This is achieved by calling device_control() routine
> with TERMINATE_ALL as parameter.
>
> This is also required to be done in case module is removed while we are in
> middle of some transfers.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
Applied, thanks

> ---
> drivers/dma/dmatest.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index b4f5c32..cd8ae03 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -476,6 +476,8 @@ err_srcs:
> pr_notice("%s: terminating after %u tests, %u failures (status %d)\n",
> thread_name, total_tests, failed_tests, ret);
>
> + /* terminate all transfers on specified channels */
> + chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
> if (iterations > 0)
> while (!kthread_should_stop()) {
> DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wait_dmatest_exit);
> @@ -498,6 +500,10 @@ static void dmatest_cleanup_channel(struct dmatest_chan *dtc)
> list_del(&thread->node);
> kfree(thread);
> }
> +
> + /* terminate all transfers on specified channels */
> + dtc->chan->device->device_control(dtc->chan, DMA_TERMINATE_ALL, 0);
> +
> kfree(dtc);
> }
>


--
~Vinod



\
 
 \ /
  Last update: 2011-08-08 16:11    [W:0.035 / U:1.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site