Messages in this thread | | | Date | Mon, 08 Aug 2011 00:10:55 +0000 | From | Florian Tobias Schandinat <> | Subject | Re: [PATCH V2] viafb: replace strict_strtoul to kstrto* and check return value |
| |
On 08/07/2011 11:42 PM, stufever@gmail.com wrote: > diff --git drivers/video/via/viafbdev.c drivers/video/via/viafbdev.c
Um, you did something different this time, causing another (not critical) checkpatch warning WARNING: patch prefix 'drivers' exists, appears to be a -p0 patch
> @@ -1325,7 +1328,8 @@ static ssize_t viafb_dfpl_proc_write(struct file *file, > if (copy_from_user(&buf[0], buffer, length)) > return -EFAULT; > buf[length - 1] = '\0'; /*Ensure end string */ > - strict_strtoul(&buf[0], 0, (unsigned long *)®_val); > + if (kstrtou8(buf, -1,®_val)< 0)
Did you miss my comment about the -1 above last time? Why it is there?
> + return -EINVAL; > viafb_write_reg_mask(CR99, VIACR, reg_val, 0x0f); > return count; > }
Thanks,
Florian Tobias Schandinat
| |