lkml.org 
[lkml]   [2011]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] viafb: replace strict_strtoul to kstrto* and check return value
On 08/07/2011 11:42 PM, stufever@gmail.com wrote:
> diff --git drivers/video/via/viafbdev.c drivers/video/via/viafbdev.c

Um, you did something different this time, causing another (not critical)
checkpatch warning
WARNING: patch prefix 'drivers' exists, appears to be a -p0 patch

> @@ -1325,7 +1328,8 @@ static ssize_t viafb_dfpl_proc_write(struct file *file,
> if (copy_from_user(&buf[0], buffer, length))
> return -EFAULT;
> buf[length - 1] = '\0'; /*Ensure end string */
> - strict_strtoul(&buf[0], 0, (unsigned long *)&reg_val);
> + if (kstrtou8(buf, -1,&reg_val)< 0)

Did you miss my comment about the -1 above last time? Why it is there?

> + return -EINVAL;
> viafb_write_reg_mask(CR99, VIACR, reg_val, 0x0f);
> return count;
> }

Thanks,

Florian Tobias Schandinat


\
 
 \ /
  Last update: 2011-08-08 02:13    [W:0.060 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site