Messages in this thread | | | From | Linus Torvalds <> | Date | Sun, 7 Aug 2011 13:17:35 -0700 | Subject | Re: [PATCH] lib/sha1: use the git implementation of SHA-1 |
| |
On Sun, Aug 7, 2011 at 12:47 PM, Andreas Schwab <schwab@linux-m68k.org> wrote: > > ARM has its own implementation of sha_transform in arch/arm/lib/sha1.S, > which assumes SHA_WORKSPACE_WORDS is 80.
Well, that certainly explains it.
I wonder if that thing is worth it. It seems to be based on the bad slow version of sha1, so I suspect that the biggest advantage of it may the byte-swapping being done more efficiently. The ARM version of "get_unaligned_be32()" is potentially pretty bad.
Joachim, does it all work for you if you just remove 'sha1.o' from lib-y in arch/arm/lib/Makefile?
Nico (now with corrected email address): is that ARM-optimized asm really worth it? Compared to the git C implementation?
Linus
| |