Messages in this thread | | | Date | Sun, 07 Aug 2011 17:47:33 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH] Don't use the deprecated function check_region |
| |
At Sat, 6 Aug 2011 23:29:17 +0800, stufever@gmail.com wrote: > > From: Wang Shaoyan <wangshaoyan.pt@taobao.com> > > sound/oss/pss.c: In function 'configure_nonsound_components': > sound/oss/pss.c:676: warning: 'check_region' is deprecated (declared at include/linux/ioport.h:201) > > --- > sound/oss/pss.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/oss/pss.c b/sound/oss/pss.c > index 9b800ce..b8ff41a 100644 > --- a/sound/oss/pss.c > +++ b/sound/oss/pss.c > @@ -673,7 +673,7 @@ static void configure_nonsound_components(void) > > if (pss_cdrom_port == -1) { /* If cdrom port enablation wasn't requested */ > printk(KERN_INFO "PSS: CDROM port not enabled.\n"); > - } else if (check_region(pss_cdrom_port, 2)) { > + } else if (check_mem_region(pss_cdrom_port, 2)) {
It's no memory region, so this conversion doesn't look correct. The right fix would be to change the driver to actually manage the resources.
thanks,
Takashi
| |