lkml.org 
[lkml]   [2011]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] stop_machine: build unconditionally if SMP
On Sun, Aug 7, 2011 at 13:09, Tejun Heo <tj@kernel.org> wrote:
> On Sat, Aug 06, 2011 at 04:38:37PM -0700, Andrew Morton wrote:
>> The priority is unclear.  It appears that the patch fixes a build error
>> under sone circumstances in current mainline?
>
> I don't think it would have triggered build error as there are dummy
> functions which just calls the function on the local CPU, but it does
> look pretty broken now.  e.g. ia64 supports memory hotplug which
> depends on stop machine but it would still be using dummy local
> version, which can't be right.

Right. Although I guess most people build with MODULE_UNLOAD enabled,
so wouldn't hit the problem.

> Robin, is there an open bug report regarding this issue?  I'm not sure
> enough to suggest -stable but definitely mainline material.

There's no bug report. I noticed it because I sometimes build ARM
kernels with module support and HOTPLUG_CPU disabled.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-08-07 11:33    [W:0.047 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site