Messages in this thread | | | Date | Thu, 4 Aug 2011 21:27:30 -0700 | From | Greg KH <> | Subject | Re: [Nbd] [PATCH v2] nbd: nbd sysfs framework |
| |
On Fri, Aug 05, 2011 at 03:47:52AM +0200, Wouter Verhelst wrote: > On Thu, Aug 04, 2011 at 06:11:27PM -0400, paul.clements@steeleye.com wrote: > > diff --git a/Documentation/ABI/testing/sysfs-block-nbd b/Documentation/ABI/testing/sysfs-block-nbd > > new file mode 100644 > > index 0000000..3728d9f > > --- /dev/null > > +++ b/Documentation/ABI/testing/sysfs-block-nbd > > @@ -0,0 +1,8 @@ > > +What: /sys/block/nbd<id>/nbd/pid > > +Date: August 2011 > > +Contact: Paul Clements <paul.clements@steeleye.com> > > +Description: > > + The pid file is read-only and specifies the pid of the > > + caller of NBD_DO_IT ioctl (normally this is the nbd-client). > > + The pid will be zero if the nbd connection is not > > + currently established. > > That's different from current behaviour: in the current implementation, > the absense of a connection is signalled by the absense of the PID file, > rather than the contents being zero. Dunno whether that change is > intentional, but I thought I'd check before changing nbd-client code...
The current behavior should not change, so that would be a bug and yet another reason to reject this patch :)
| |