Messages in this thread | | | Date | Fri, 5 Aug 2011 12:43:57 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86, olpc: Wait for last byte of EC command to be accepted |
| |
* Daniel Drake <dsd@laptop.org> wrote:
> From: Paul Fox <pgf@laptop.org> > > When executing EC commands, only waiting when there are still more bytes to > write is usually fine. However, if the system suspends very quickly after > a call to olpc_ec_cmd(), the last data byte may not yet be transferred to > the EC, and the command will not complete. > > This solves a bug where the SCI wakeup mask was not correctly written > when going into suspend.
What did that result in - a resume hang? (i.e. how urgent is this fix - v3.1 material or v3.2 material?)
Thanks,
Ingo
| |