lkml.org 
[lkml]   [2011]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [stable] [patch 3/3] rtc: Limit frequency
On 07/22/2011 18:39, Willy Tarreau wrote:
> On Fri, Jul 22, 2011 at 03:05:50PM -0700, Andrew Morton wrote:
>> On Fri, 22 Jul 2011 09:12:51 -0000
>> Thomas Gleixner <tglx@linutronix.de> wrote:
>>
>>> The RTC hrtimer is self rearming. We really need to limit the
>>> frequency to something sensible.
>>
>>> Cc: stable@kernel.org
>>
>> Why? What failures does the current code cause? What effect do these
>> failures have upon users?
>
> I would add that if we go that route, we should at least accept values
> that were documented as possible till now. Man rtc says 2 Hz to 8192 Hz,
> but Thomas' proposed patch limits it to 5000 Hz, so some breakage is to
> be expected.
>
> Regards,
> Willy

To me, it would make sense to lock it at 8192Hz. I re-wrote a driver for the DS1685 family of Dallas chips that I need
to cleanup and re-submit, but in researching that specific RTC, I really could not find an RTC out there that went above
8192.

Arguably, 32768Hz might also work. The DS1685 runs at this mode normally, but it disables PIE when it does.

My vote is 8192Hz.

Also, can we get a wrapper of some kind in the RTC core to allow an RTC driver to override the hrtimer /PIE emulation if
needed? I have in the DS1685 driver full support for its PIE mode and really do not want to gut it as part of the
cleanup. Some kind of override API would be nice in case anyone ever runs into this chip (or its family members).

--
Joshua Kinard
Gentoo/MIPS
kumba@gentoo.org

"The past tempts us, the present confuses us, the future frightens us. And our lives slip away, moment by moment, lost
in that vast, terrible in-between."

--Emperor Turhan, Centauri Republic


\
 
 \ /
  Last update: 2011-08-05 05:49    [W:0.113 / U:0.012 seconds]
©2003-2014 Jasper Spaans. Advertise on this site