Messages in this thread | | | From | Grant Likely <> | Date | Fri, 5 Aug 2011 00:32:15 +0100 | Subject | Re: [PATCH] devtmpfs: Fix section mismatch on devtmpfsd() |
| |
On Thu, Aug 4, 2011 at 11:54 PM, Greg KH <gregkh@suse.de> wrote: > On Thu, Aug 04, 2011 at 11:36:11PM +0100, Grant Likely wrote: >> devtmpfsd_init() references setup_done which is __initdata, but >> devtmpfsd() is not an __init function. The code is fine, because it >> is never referenced after discarding __init sections, but it leaves >> some additional code that can be discarded with the rest of __init and >> it causes gcc to complain with a section mismatch warning. > > I have a simpler patch here that just removes the __initdata function, > which is simpler. > > I hate the initdata stuff, it's almost always pointless...
initdata I don't mind. Discarding stuff that is no longer necessary isn't a bad thing and I don't find it that onerous. __devinit* seems less useful since I've never worked on a system that can actually discard it.
> Would that solve the problem for you as well?
Sure. I was just doing random sparc builds and fixing up the bugs I ran into. I'm happy with that solution too.
g.
g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |