lkml.org 
[lkml]   [2011]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] HID: kfree() NULL pointer cleanup
    Date
    Checking for NULL pointers before kfree() is redundant.

    Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
    ---
    drivers/hid/hid-prodikeys.c | 4 +---
    1 files changed, 1 insertions(+), 3 deletions(-)

    diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
    index 158b389..62f95d4 100644
    --- a/drivers/hid/hid-prodikeys.c
    +++ b/drivers/hid/hid-prodikeys.c
    @@ -849,9 +849,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
    err_stop:
    hid_hw_stop(hdev);
    err_free:
    - if (pm != NULL)
    - kfree(pm);
    -
    + kfree(pm);
    kfree(pk);
    return ret;
    }
    --
    1.7.1


    \
     
     \ /
      Last update: 2011-08-04 22:45    [W:0.020 / U:0.620 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site