Messages in this thread | | | Subject | Re: [PATCH 18/24] sctp: Remove unnecessary OOM logging messages | From | Joe Perches <> | Date | Wed, 31 Aug 2011 17:25:11 -0700 |
| |
On Mon, 2011-08-29 at 18:15 -0400, David Miller wrote: > From: Eric Dumazet <eric.dumazet@gmail.com> > Date: Mon, 29 Aug 2011 23:51:21 +0200 > > Le lundi 29 août 2011 à 23:43 +0200, Eric Dumazet a écrit : > >> Furthermore, a failed vmalloc() is not guaranteed to emit an OOM > >> message, is it ? > > It currently displays a message without context : > > vmap allocation for size XXXXXX failed: use vmalloc=<size> to increase > > size. > > So we dont know which part of the kernel asked this allocation. > > Please dont remove existing error messages after failed vmalloc() calls. > Indeed. > Joe, these vmalloc() and also the __GFP_NOWARN cases will need to be > attended to and this series resubmitted as such.
No worries.
Andrew Morton picked up a patch I posted that changes vmalloc to be similar to kmalloc when the pointer returned is NULL (OOM). It now uses dump_stack for those cases.
https://patchwork.kernel.org/patch/1114682/
I'll keep all the current vmalloc failure messages for now and resubmit in a day or two this series with acks. Not batman or netfilter though as they were picked up by their maintainers.
A month or two after the vmalloc patch hits mainline and/or wider testing, and it's deemed acceptable, removing vmalloc site specific OOM messages should be appropriate.
Anyone object?
I plan on submitting drivers/net OOM removals next week.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |