Messages in this thread | | | Date | Wed, 31 Aug 2011 09:03:13 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH 6/6] cgroup: kill subsys->can_attach_task(), pre_attach() and attach_task() |
| |
Hello, Frederic.
On Tue, Aug 30, 2011 at 10:10:32PM +0200, Frederic Weisbecker wrote: > In order to keep the fix queued in -mm (https://lkml.org/lkml/2011/8/26/262) > the tasks that have failed to migrate should be removed from the iterator > so that they are not included in the batch in ->attach().
I don't think that's a good approach. It breaks the symmetry when calling different callbacks. What if ->can_attach() allocates per-task resources and the task exits in the middle? I think we better lock down fork/exit/exec. I'll send patches but I'm currently moving / traveling w/ limited access to my toys so it might take some time.
Thanks.
-- tejun
| |