lkml.org 
[lkml]   [2011]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/6] cgroup: kill subsys->can_attach_task(), pre_attach() and attach_task()
Hello, Frederic.

On Tue, Aug 30, 2011 at 10:10:32PM +0200, Frederic Weisbecker wrote:
> In order to keep the fix queued in -mm (https://lkml.org/lkml/2011/8/26/262)
> the tasks that have failed to migrate should be removed from the iterator
> so that they are not included in the batch in ->attach().

I don't think that's a good approach. It breaks the symmetry when
calling different callbacks. What if ->can_attach() allocates
per-task resources and the task exits in the middle? I think we
better lock down fork/exit/exec. I'll send patches but I'm currently
moving / traveling w/ limited access to my toys so it might take some
time.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-08-31 09:05    [W:0.151 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site