lkml.org 
[lkml]   [2011]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 10/18] Staging: cx25821: Fix long lines in cx25821-audio-upstream.c
    On Tue, 30 Aug 2011 17:12:50 +0300
    Dan Carpenter <error27@gmail.com> wrote:

    > On Tue, Aug 30, 2011 at 12:17:05PM +0800, Leonid V. Fedorenchik wrote:
    > > @@ -603,7 +599,8 @@ static irqreturn_t cx25821_upstream_irq_audio(int irq, void *dev_id)
    > > if (!dev)
    > > return -1;
    > >
    > > - sram_ch = dev->channels[dev->_audio_upstream_channel_select].sram_channels;
    > > + sram_ch = dev->channels[dev->_audio_upstream_channel_select].
    > > + sram_channels;
    >
    > $ echo -n "_audio_upstream_channel_select" | wc -c
    > 30
    >
    > I think I may have found the problem. (Don't use variable names that
    > are a 30 zillion chars long).
    Yes, it's long, but I don't really know how to make it shorter. Is
    _audio_upstream_channel OK?

    >
    > regards,
    > dan carpenter
    >



    Leonid V. Fedorenchik


    \
     
     \ /
      Last update: 2011-08-31 08:59    [W:0.020 / U:59.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site