lkml.org 
[lkml]   [2011]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] RDMA/cxgb4: remove accidentally left mutex_unlock(&dev_mutex)
On 08/31/2011 03:43 PM, Alexey Khoroshilov wrote:
> The patch "RDMA/cxgb4: EEH errors can hang the driver" removes
> mutex lock/unlock from c4iw_alloc() except for error path.
> This patch removes the remained mutex_unlock(&dev_mutex).
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov<khoroshilov@ispras.ru>
> ---
> drivers/infiniband/hw/cxgb4/device.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index 40a13cc..35896ff 100644
> --- a/drivers/infiniband/hw/cxgb4/device.c
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -414,7 +414,6 @@ static struct c4iw_dev *c4iw_alloc(const struct cxgb4_lld_info *infop)
>
> ret = c4iw_rdev_open(&devp->rdev);
> if (ret) {
> - mutex_unlock(&dev_mutex);
> printk(KERN_ERR MOD "Unable to open CXIO rdev err %d\n", ret);
> ib_dealloc_device(&devp->ibdev);
> return ERR_PTR(ret);

This is actually included in my previously submitted patch:

https://patchwork.kernel.org/patch/1026942/

Steve.




\
 
 \ /
  Last update: 2011-08-31 22:49    [W:0.026 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site