[lkml]   [2011]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 3/4] TTY: serial, fix build of some drivers
    I'm getting build errors such as:
    .../tty/serial/max3107.c: In function ‘put_data_to_circ_buf’:
    .../tty/serial/max3107.c:149:2: error: implicit declaration of function ‘tty_insert_flip_string’

    Those drivers need to include linux/tty_flip.h. The question is
    whether we want to fix them at all. As they are broken for some time
    already and nobody noticed...

    Signed-off-by: Jiri Slaby <>
    Cc: Alan Cox <>
    drivers/tty/serial/max3107.c | 1 +
    drivers/tty/serial/timbuart.c | 1 +
    2 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/tty/serial/max3107.c b/drivers/tty/serial/max3107.c
    index a50f406..a33ff77 100644
    --- a/drivers/tty/serial/max3107.c
    +++ b/drivers/tty/serial/max3107.c
    @@ -35,6 +35,7 @@
    #include <linux/spi/spi.h>
    #include <linux/freezer.h>
    #include <linux/module.h>
    +#include <linux/tty_flip.h>
    #include "max3107.h"

    static const struct baud_table brg26_ext[] = {
    diff --git a/drivers/tty/serial/timbuart.c b/drivers/tty/serial/timbuart.c
    index e213535..3a4da87 100644
    --- a/drivers/tty/serial/timbuart.c
    +++ b/drivers/tty/serial/timbuart.c
    @@ -28,6 +28,7 @@
    #include <linux/ioport.h>
    #include <linux/slab.h>
    #include <linux/module.h>
    +#include <linux/tty_flip.h>

    #include "timbuart.h"


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-08-31 21:29    [W:0.022 / U:12.208 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site