Messages in this thread | | | Date | Wed, 31 Aug 2011 14:26:28 +0100 | From | Liam Girdwood <> | Subject | Re: [PATCH 1/2 RESEND] regulator: aat2870: Fix the logic of checking if no id is matched in aat2870_get_regulator |
| |
On 29/08/11 15:48, Axel Lin wrote: > In current implementation, the pointer ri is not NULL if no id is matched. > Fix it by checking i == ARRAY_SIZE(aat2870_regulators) if no id is matched. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > --- > drivers/regulator/aat2870-regulator.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c > index cd41045..11d1ab4 100644 > --- a/drivers/regulator/aat2870-regulator.c > +++ b/drivers/regulator/aat2870-regulator.c > @@ -159,7 +159,7 @@ static struct aat2870_regulator *aat2870_get_regulator(int id) > break; > } > > - if (!ri) > + if (i == ARRAY_SIZE(aat2870_regulators)) > return NULL; > > ri->enable_addr = AAT2870_LDO_EN;
Both applied.
Thanks
Liam
| |