lkml.org 
[lkml]   [2011]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] mm: vmalloc - Report more vmalloc failures
From
Date
Some vmalloc failure paths do not report OOM conditions.

Add warn_alloc_failed, which also does a dump_stack,
to those failure paths.

This allows more site specific vmalloc failure
logging message printks to be removed.

Signed-off-by: Joe Perches <joe@perches.com>
---
mm/vmalloc.c | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 3122acc..5108e0b 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1600,13 +1600,12 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,

size = PAGE_ALIGN(size);
if (!size || (size >> PAGE_SHIFT) > totalram_pages)
- return NULL;
+ goto fail;

area = __get_vm_area_node(size, align, VM_ALLOC, start, end, node,
gfp_mask, caller);
-
if (!area)
- return NULL;
+ goto fail;

addr = __vmalloc_area_node(area, gfp_mask, prot, node, caller);

@@ -1618,6 +1617,12 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,
kmemleak_alloc(addr, real_size, 3, gfp_mask);

return addr;
+
+fail:
+ warn_alloc_failed(gfp_mask, 0,
+ "vmalloc: allocation failure: %lu bytes\n",
+ real_size);
+ return NULL;
}

/**



\
 
 \ /
  Last update: 2011-08-31 03:47    [W:0.023 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site