Messages in this thread | | | Date | Tue, 30 Aug 2011 14:51:17 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH] misc: Remove obsolete cleanup for clientdata |
| |
On Thu, 25 Aug 2011 12:54:04 +0200, Wolfram Sang wrote: > A few new i2c-drivers came into the kernel which clear the clientdata-pointer > on exit or error. This is obsolete meanwhile, the core will do it. > > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Minkyu Kang <mk7.kang@samsung.com> > Cc: Donggeun Kim <dg77.kim@samsung.com> > --- > drivers/misc/fsa9480.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/fsa9480.c b/drivers/misc/fsa9480.c > index 5325a7e..22e22ad 100644 > --- a/drivers/misc/fsa9480.c > +++ b/drivers/misc/fsa9480.c > @@ -457,7 +457,6 @@ fail2: > if (client->irq) > free_irq(client->irq, NULL); > fail1: > - i2c_set_clientdata(client, NULL); > kfree(usbsw); > return ret; > } > @@ -467,7 +466,6 @@ static int __devexit fsa9480_remove(struct i2c_client *client) > struct fsa9480_usbsw *usbsw = i2c_get_clientdata(client); > if (client->irq) > free_irq(client->irq, NULL); > - i2c_set_clientdata(client, NULL); > > sysfs_remove_group(&client->dev.kobj, &fsa9480_group); > device_init_wakeup(&client->dev, 0);
You'll have to refresh this one, as the context was changed by b89d5f17d4b02ae9f3a691c2cb260e1929c6261b.
-- Jean Delvare
| |