lkml.org 
[lkml]   [2011]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[100/102] dm snapshot: flush disk cache when merging
    3.0-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Mikulas Patocka <mpatocka@redhat.com>

    commit 762a80d9fc9f690a3a35983f3b4619a220650808 upstream.

    This patch makes dm-snapshot flush disk cache when writing metadata for
    merging snapshot.

    Without cache flushing the disk may reorder metadata write and other
    data writes and there is a possibility of data corruption in case of
    power fault.

    Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
    Signed-off-by: Alasdair G Kergon <agk@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/md/dm-snap-persistent.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/md/dm-snap-persistent.c
    +++ b/drivers/md/dm-snap-persistent.c
    @@ -753,7 +753,7 @@ static int persistent_commit_merge(struc
    for (i = 0; i < nr_merged; i++)
    clear_exception(ps, ps->current_committed - 1 - i);

    - r = area_io(ps, WRITE);
    + r = area_io(ps, WRITE_FLUSH_FUA);
    if (r < 0)
    return r;




    \
     
     \ /
      Last update: 2011-08-04 01:33    [W:0.022 / U:0.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site