lkml.org 
[lkml]   [2011]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages
    On Wed, Aug 03, 2011 at 02:44:20PM +0100, Mel Gorman wrote:
    > On Wed, Aug 03, 2011 at 01:06:29PM +0200, Johannes Weiner wrote:
    > > On Wed, Aug 03, 2011 at 12:58:19PM +0200, Johannes Weiner wrote:
    > > > On Thu, Jul 21, 2011 at 05:28:45PM +0100, Mel Gorman wrote:
    > > > > Direct reclaim should never writeback pages. Warn if an attempt
    > > > > is made.
    > > > >
    > > > > Signed-off-by: Mel Gorman <mgorman@suse.de>
    > > >
    > > > Acked-by: Johannes Weiner <jweiner@redhat.com>
    > >
    > > Oops, too fast.
    > >
    > > Shouldn't the WARN_ON() be at the top of the function, rather than
    > > just warn when the write is deferred due to delalloc?
    >
    > I thought it made more sense to put the warning at the point where ext4
    > would normally ignore ->writepage.
    >
    > That said, in my current revision of the series, I've dropped these
    > patches altogether as page migration should be able to trigger the same
    > warnings but be called from paths that are of less concern for stack
    > overflows (or at the very least be looked at as a separate series).

    Doesn't this only apply to btrfs which has no own .migratepage aop for
    file pages? The others use buffer_migrate_page.

    But if you dropped them anyway, it does not matter :)


    \
     
     \ /
      Last update: 2011-08-03 16:03    [W:0.034 / U:91.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site