lkml.org 
[lkml]   [2011]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [tip:perf/urgent] perf sched: Fix list of events, dropping unsupported ':r' modifier
From
Date
On Wed, 2011-08-03 at 13:37 +0200, Frederic Weisbecker wrote:
> On Wed, Aug 03, 2011 at 12:59:21PM +0200, Peter Zijlstra wrote:
> > On Fri, 2011-01-14 at 07:25 +0000, tip-bot for Stephane Eranian wrote:
> > > Looks to me like the :r modifier is not supported anymore, so remove it from
> > > the list of events.
> >
> > acme, why is that anyway? -R is a fun way to save some typing, but not
> > supporting :r anymore takes away the option of not getting
> > PERF_SAMPLE_RAW output for every event.
>
> Because it was very non obvious for people to select this -R or :r
> every time they wanted to use trace events for tracing. I think
> there was complaints about that. Moreover nobody seemed to use
> trace events for non-tracing (perf report, top, annotate, ...)
> so we decided to always have RAW records so that it works for
> every cases...unless we lose events because of that.
>
> We can still bring an option to force disabling of raw records.

That just doesn't compute, they still have to use -R, so what's the harm
in also having :r?

Also taking away options just because it confuses people sounds like
gnome, lets just not go there.


\
 
 \ /
  Last update: 2011-08-03 13:45    [W:0.049 / U:1.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site