Messages in this thread | | | Date | Mon, 29 Aug 2011 14:54:59 -0700 | From | Boaz Harrosh <> | Subject | Re: [PATCH 19/24] sunrpc: Remove unnecessary OOM logging messages |
| |
On 08/29/2011 02:37 PM, David Miller wrote: > From: "Myklebust, Trond" <Trond.Myklebust@netapp.com> > Date: Mon, 29 Aug 2011 14:36:17 -0700 > >> Big NACK... >> >> By whose standard are those "not useful"? > > By mine, that's for sure. It's duplicating something that the allocation > layers are already going to print.
I have a question about that. Are the dprints going to show the stack backtrace? Otherwise how can I see which exact allocation failed and was not properly handled?
If yes above? then I'm not sure I like it either, because am I'll be getting a full stack backtrace for every failed allocation?
But I might like it if I try. How do I turn on allocation failures prints? Can I filter out to print only GFP_KERNEL failures and or other GFP combinations?
Thanks Boaz
| |