Messages in this thread | | | Date | Mon, 29 Aug 2011 11:09:34 -0700 | From | Greg KH <> | Subject | Re: [PATCH 44/46] Staging: hv: vmbus: Fix checkpatch warnings in connection.c |
| |
On Sat, Aug 27, 2011 at 11:31:43AM -0700, K. Y. Srinivasan wrote: > Fix checkpatch warnings in connection.c. > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> > --- > drivers/staging/hv/connection.c | 13 +++++++------ > 1 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/hv/connection.c b/drivers/staging/hv/connection.c > index ca92ca3..9e99c04 100644 > --- a/drivers/staging/hv/connection.c > +++ b/drivers/staging/hv/connection.c > @@ -220,11 +220,11 @@ static void process_chn_event(u32 relid) > channel = relid2channel(relid); > > spin_lock_irqsave(&channel->inbound_lock, flags); > - if (channel && (channel->onchannel_callback != NULL)) { > + if (channel && (channel->onchannel_callback != NULL)) > channel->onchannel_callback(channel->channel_callback_context); > - } else {
I agree with Joe here, if channel really was NULL, you just oopsed.
I'll apply this one, but please send me a follow-on one fixing this bug.
greg k-h
| |