lkml.org 
[lkml]   [2011]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/32 RESEND] nohz: Drop useless call in tick_nohz_start_idle()
    From
    Date
    On Mon, 2011-08-15 at 17:51 +0200, Frederic Weisbecker wrote:
    > The call to update_ts_time_stats() there is useless. All
    > we need is to save the idle entry_time.
    >
    >
    Would have been clearer if you just said the call was a NOP. The whole
    second sentence distracts and confuses as its irrelevant to the change
    at hand.

    If you want to expand you can explain that its a NOP because
    update_ts_time_stats() requires either ts->idle_active and/or
    @last_update_time and our callsite has neither.

    Although this assumes its never called when ts->idle_active is already
    set, is this so (likely)? Do we want a WARN_ON_ONCE() testing that
    assumption?


    \
     
     \ /
      Last update: 2011-08-29 16:25    [W:3.137 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site