lkml.org 
[lkml]   [2011]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Drbd-dev] [RFC 000/118] drbd: part 1 of adding multiple volume support to drbd
Date
Am Freitag, 26. August 2011, 15:20:51 schrieb Greg Freemyer:
> On Thu, Aug 25, 2011 at 11:06 AM, Philipp Reisner <
>
> philipp.reisner@linbit.com> wrote:
> > This the first request for review of drbd-8.4. The complete set has
> > 500 patches. In this first series there are only 118 of these.
>
> Lars,
>
> I've only taken a quick glance, but is drbd functional between applying
> each patch?
>
> It doesn't look like it to me, but I didn't look that close. I also saw at
> least one patch that introduced a new function with no caller to test it.
>
> The idea is that a patch series leave a testable / functional kernel after
> each patch in the series is applied sequentially.
>
> That is the only way git bisect can do its job.
>
> ie. Introducing a new function but no new caller makes a change, but there
> is no way to test it. Therefore there is no real value in not merging that
> patch with one that has the new call in it.
>

Greg,

You replied to mail 000. Please point out to which patch/function you
refer, so that we can fix this.

Best,
Phil
--
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com

DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.


\
 
 \ /
  Last update: 2011-08-29 13:49    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site