| Subject | Re: [PATCH 44/46] Staging: hv: vmbus: Fix checkpatch warnings in connection.c | From | Joe Perches <> | Date | Sat, 27 Aug 2011 23:56:52 -0700 |
| |
On Sat, 2011-08-27 at 11:31 -0700, K. Y. Srinivasan wrote: > Fix checkpatch warnings in connection.c. [] > diff --git a/drivers/staging/hv/connection.c b/drivers/staging/hv/connection.c [] > @@ -220,11 +220,11 @@ static void process_chn_event(u32 relid) > channel = relid2channel(relid); > > spin_lock_irqsave(&channel->inbound_lock, flags); > - if (channel && (channel->onchannel_callback != NULL)) { > + if (channel && (channel->onchannel_callback != NULL))
Useless test for channel or bad placement for spin_lock. channel has already been dereferenced by the spin_lock.
|