lkml.org 
[lkml]   [2011]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 27/46] Staging: hv: storvsc: Fixup srb and scsi status for INQUIRY and MODE_SENSE
    Date
    The current VHD handler on the Windows Host does not correctly handle
    INQUIRY and MODE_SENSE commands with some options. Fixup srb_status
    in these cases since the failure is not fatal.

    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
    ---
    drivers/staging/hv/storvsc_drv.c | 17 +++++++++++++++++
    1 files changed, 17 insertions(+), 0 deletions(-)

    diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
    index 0bb4e0e..72ca25c 100644
    --- a/drivers/staging/hv/storvsc_drv.c
    +++ b/drivers/staging/hv/storvsc_drv.c
    @@ -512,6 +512,23 @@ static void storvsc_on_io_completion(struct hv_device *device,

    stor_pkt = &request->vstor_packet;

    + /*
    + * The current SCSI handling on the host side does
    + * not correctly handle:
    + * INQUIRY command with page code parameter set to 0x80
    + * MODE_SENSE command with cmd[2] == 0x1c
    + *
    + * Setup srb and scsi status so this won't be fatal.
    + * We do this so we can distinguish truly fatal failues
    + * (srb status == 0x4) and off-line the device in that case.
    + */
    +
    + if ((stor_pkt->vm_srb.cdb[0] == INQUIRY) ||
    + (stor_pkt->vm_srb.cdb[0] == MODE_SENSE)) {
    + vstor_packet->vm_srb.scsi_status = 0;
    + vstor_packet->vm_srb.srb_status = 0x1;
    + }
    +

    /* Copy over the status...etc */
    stor_pkt->vm_srb.scsi_status = vstor_packet->vm_srb.scsi_status;
    --
    1.7.4.1


    \
     
     \ /
      Last update: 2011-08-27 20:21    [W:0.022 / U:31.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site