lkml.org 
[lkml]   [2011]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 06/14] [media] cx18: Use current logging styles
    From
    Date
    On Sat, 2011-08-27 at 19:05 +0200, Jean-Francois Moine wrote:
    > On Sat, 27 Aug 2011 09:42:32 -0700
    > Joe Perches <joe@perches.com> wrote:
    >
    > > Andy, I fully understand how this stuff works.
    > > You apparently don't (yet).
    > >
    > > Look at include/linux/printk.h
    > >
    > > #ifndef pr_fmt
    > > #define pr_fmt(fmt) fmt
    > > #endif
    > >
    > > A default empty define is used when one
    > > is not specified before printk.h is
    > > included. kernel.h includes printk.h
    >
    > Hi Joe,
    >
    > Yes, but, what if pr_fmt is redefined in some driver specific include
    > by:
    >
    > #undef pr_fmt
    > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

    Of course that's possible.

    But any pr_<level> that is used by any .h file
    that is included before this redefine like
    for instance netdevice.h doesn't have a
    properly specified pr_fmt.




    \
     
     \ /
      Last update: 2011-08-27 19:33    [W:0.019 / U:0.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site