lkml.org 
[lkml]   [2011]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: brcmfmac: Consolidate debugging macros
From
Date
On Fri, 2011-08-26 at 10:55 +0200, Rafał Miłecki wrote:
> 2011/8/25 Joe Perches <joe@perches.com>:
> > Convert multiple BRCMF_<debug_level> macros to a single
> > brcmf_dbg(level, fmt, ...) macro.
> I'm not sure if that "_dbg" suffix is a really good choice. You use
> "_dbg" for all the kinds of messages, while "DEBUG" is already one
> kind of messages.

No, not really. These _are_ debugging uses.

The #include is called dhd_dbg.h and
the whole block is guarded by

#if defined(BCMDBG)

> We have also other types like EMERG, ALERT, CRIT,
> ERR, WARNING, NOTICE, INFO and DEBUG.

Except for the last, those aren't debugging uses,
these are.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-08-26 11:05    [W:0.592 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site