Messages in this thread Patch in this message | | | From | Greg Kroah-Hartman <> | Subject | [PATCH 12/13] drivers:misc: ti-st: free skb on firmware download | Date | Fri, 26 Aug 2011 13:33:53 -0700 |
| |
From: Pavan Savoy <pavan_savoy@ti.com>
If during validation of the firmware download the data doesn't match what is expected out of the chip, this calls for a firmware download failure and a retry. Free the SKB which collects response during such scenarios.
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/misc/ti-st/st_kim.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index d8ca406..3a35805 100644 --- a/drivers/misc/ti-st/st_kim.c +++ b/drivers/misc/ti-st/st_kim.c @@ -68,6 +68,7 @@ void validate_firmware_response(struct kim_data_s *kim_gdata) if (unlikely(skb->data[5] != 0)) { pr_err("no proper response during fw download"); pr_err("data6 %x", skb->data[5]); + kfree_skb(skb); return; /* keep waiting for the proper response */ } /* becos of all the script being downloaded */ -- 1.7.6.1
| |