Messages in this thread Patch in this message | | | Date | Fri, 26 Aug 2011 13:13:19 +0800 | Subject | [PATCH] slab: avoid unnecessary touching of a partial slab | From | Zhao Jin <> |
| |
In cache_alloc_refill(), after refilling from a partial slab, if the slab remains partial, it would be deleted from and then added again to the partial list. As the slab is the first element in the list before deletion, such behavior has no effect. This patch avoids touching the slab in this case.
Signed-off-by: Zhao Jin <cronozhj@gmail.com> --- mm/slab.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/mm/slab.c b/mm/slab.c index 6d90a09..3469c6f 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -3121,11 +3121,14 @@ retry: check_slabp(cachep, slabp);
/* move slabp to correct slabp list: */ - list_del(&slabp->list); - if (slabp->free == BUFCTL_END) + if (slabp->free == BUFCTL_END) { + list_del(&slabp->list); list_add(&slabp->list, &l3->slabs_full); - else + } + else if (&slabp->list != l3->slabs_partial.next) { + list_del(&slabp->list); list_add(&slabp->list, &l3->slabs_partial); + } }
must_grow: -- 1.7.4.1
| |