lkml.org 
[lkml]   [2011]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/5] TTY: use tty_wait_until_sent_from_close in tty_port_close_start
    Date
    Let's use the newly added helper to avoid stalls in drivers which are
    already ported to tty_port helpers.

    We have to ensure here, that there is no user of tty_port_close_start
    and tty_port_close which holds port->mutex (or other) lock over them.
    And sure, there is none.

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/tty/tty_port.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
    index 33d37d2..ef9dd62 100644
    --- a/drivers/tty/tty_port.c
    +++ b/drivers/tty/tty_port.c
    @@ -350,7 +350,7 @@ int tty_port_close_start(struct tty_port *port,
    tty_driver_flush_buffer(tty);
    if (test_bit(ASYNCB_INITIALIZED, &port->flags) &&
    port->closing_wait != ASYNC_CLOSING_WAIT_NONE)
    - tty_wait_until_sent(tty, port->closing_wait);
    + tty_wait_until_sent_from_close(tty, port->closing_wait);
    if (port->drain_delay) {
    unsigned int bps = tty_get_baud_rate(tty);
    long timeout;
    --
    1.7.6



    \
     
     \ /
      Last update: 2011-08-25 15:15    [W:0.021 / U:34.328 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site