lkml.org 
[lkml]   [2011]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] usb: fix dwc3 build when USB_GADGET_DWC3 is not enabled
Hi,

On Tue, Aug 23, 2011 at 11:07:02AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix build error when CONFIG_USB_GADGET_DWC3 is not enabled:
>
> ERROR: "dwc3_send_gadget_ep_cmd" [drivers/usb/dwc3/dwc3.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> drivers/usb/dwc3/debugfs.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> --- linux-next-20110823.orig/drivers/usb/dwc3/debugfs.c
> +++ linux-next-20110823/drivers/usb/dwc3/debugfs.c
> @@ -437,7 +437,9 @@ static int dwc3_testmode_open(struct ino
> struct dwc3_gadget_ep_cmd_params par0;
> struct dwc3_gadget_ep_cmd_params par1;
> struct dwc3_trb trb;
> +#ifdef CONFIG_USB_GADGET_DWC3
> int ret;
> +#endif
> u8 *buf0;
> u8 *buf1;
>
> @@ -478,8 +480,10 @@ static int dwc3_testmode_open(struct ino
>
> dwc3_send_testmode_cmd(dwc, 1);
>
> +#ifdef CONFIG_USB_GADGET_DWC3
> ret = dwc3_send_gadget_ep_cmd(dwc, 0, DWC3_DEPCMD_STARTTRANSFER, &par0);
> ret = dwc3_send_gadget_ep_cmd(dwc, 1, DWC3_DEPCMD_STARTTRANSFER, &par1);
> +#endif

instead of adding the ifdef here, would you add it gadget.h and provide
a nop when we're not building the gadget side ?

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-08-23 20:55    [W:0.134 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site