Messages in this thread | | | Subject | Re: [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot | From | Greg Kurz <> | Date | Tue, 23 Aug 2011 16:09:26 +0200 |
| |
On Tue, 2011-08-23 at 15:33 +0200, Oleg Nesterov wrote: > [...] > At least now I understand why did you mention si_code/CLD before. You > meant waitid(). I thought you were talking about the death-notifications > which can't report CLD_ you need. > > I strongly object. We shouldn't uglify wait_task_zombie() to solve the > very specific problem. > > And once again. sub_init->parent does wiat(&status) and sees > WIFSIGNALED() && WTERMSIG(status) == SIGHUP. This can only mean that > sys_reboot(LINUX_REBOOT_CMD_RESTART) was called. It _can not_ be really > killed by SIGHUP, it must be CMD_RESTART. > > Why this can't work? Why do you want the additional complications? >
I don't see either what could go wrong with you approach. It doesn't mess with critical wait() or signal paths. It's definitely the way to go.
Thanks.
-- Gregory Kurz gkurz@fr.ibm.com Software Engineer @ IBM/Meiosys http://www.ibm.com Tel +33 (0)534 638 479 Fax +33 (0)561 400 420
"Anarchy is about taking complete responsibility for yourself." Alan Moore.
| |