Messages in this thread | | | Date | Mon, 22 Aug 2011 17:40:13 -0700 (PDT) | Subject | Re: [Patch] Scm: Remove unnecessary pid & credential references in Unix socket's send and receive path | From | David Miller <> |
| |
From: Tim Chen <tim.c.chen@linux.intel.com> Date: Fri, 19 Aug 2011 09:44:58 -0700
> - /* Only send the fds in the first buffer */ > - err = unix_scm_to_skb(siocb->scm, skb, !fds_sent); > + /* Only send the fds and no ref to pid in the first buffer */ > + if (fds_sent) > + err = unix_scm_to_skb(siocb->scm, skb, !fds_sent, true); > + else > + err = unix_scm_to_skb(siocb->scm, skb, !fds_sent, false);
Just set this final boolean the way the third argument is, there is no reason to replicate the entire function call twice just to set the final argument to what "fds_sent" evaluates to as a boolean.
err = unix_scm_to_skb(siocb->scm, skb, !fds_sent, fds_sent);
ought to suffice.
| |